Worker Deployment Versioning#896
Merged
Sushisource merged 5 commits intomasterfrom Apr 4, 2025
Merged
Conversation
dandavison
reviewed
Apr 3, 2025
dandavison
reviewed
Apr 3, 2025
| WorkerVersioningStrategy::LegcayBuildIdBased { build_id } => { | ||
| if build_id.is_empty() { | ||
| return Err( | ||
| "Legacy build id based versioning must have a non-empty build_id" |
Contributor
There was a problem hiding this comment.
Haha but I never know how to do this
Suggested change
| "Legacy build id based versioning must have a non-empty build_id" | |
| "Legacy build id-based versioning must have a non-empty build_id" |
Contributor
There was a problem hiding this comment.
Use a hyphen to join a pair of space-separated words with a third word.
dandavison
reviewed
Apr 3, 2025
dandavison
approved these changes
Apr 3, 2025
Contributor
dandavison
left a comment
dandavison
left a comment
There was a problem hiding this comment.
This all looks safe and uncontroversial to me, so happy to approve (but I have little context for the change being made).
cretz
approved these changes
Apr 4, 2025
Comment on lines
+515
to
+519
| /// Use the legacy build-id-based whole worker versioning. | ||
| LegacyBuildIdBased { | ||
| /// A Build ID to use, must be non-empty. | ||
| build_id: String, | ||
| }, |
Contributor
There was a problem hiding this comment.
Would support a future where this option is deleted when versioning v2 is deleted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added necessary bits to enable worker deployment based versioning
Note
Breaking change for lang implementers: I shuffled around the build id and legacy versioning stuff to make it compile-time mutually exclusive with this new stuff.
Why?
Feature train choo choo 🚄
Checklist
Closes [Feature Request] Support New Worker Versioning API #889
How was this tested:
Added fairly straightforward integ test. The testing in core isn't so valuable except to ensure the right stuff is sent to server, which is largely true for lang as well.
Any docs updates needed?